SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.56k stars 1.1k forks source link

After the update, colored text is not displayed. #3351

Open fadfhkdfga opened 2 years ago

fadfhkdfga commented 2 years ago

Bungeecord version

git:BungeeCord-Bootstrap:1.19-R0.1-SNAPSHOT:587fb37:1653

Server version

git-Paper-386 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: 072f54c on ver/1.18.2)

Client version

1.19

Bungeecord plugins

GeySer-BungeeCord floodgate-bungee HubMagic NuVotifier SlashServer

The bug

After updating the bungee code version from 1636 to 1653, the colored text output by some plugins is not displayed. ex) &aExample -> "&aExample"

Example of one plugin without colored text: TriggerReactor https://www.spigotmc.org/resources/triggerreactor-script-for-everything.40987/

Log output (links)

No response

Checking

Janmm14 commented 2 years ago

While something about chat colors was changed (in a PR by me to improve compatiblity with legacy formatting reset), there was no change in the method which allows conversion from a variable color char like & to the "true" color char §.

Therefore it would be great if you could provide a minimalistic sample showing the bug.

md-5 commented 2 years ago

Bump

Janmm14 commented 2 years ago

Seems unrealistic that the bungee change related to chat would cause not-updated spigot to not correctly convert legacy chat to json.

Edit: the issue the user openend on triggerreactor's github saids a simple #message would have this problem, but message seems to be implemented fairly simple as ChatColor.translateAlternateColorCodes (link)

Does not sound realistic.