Clear scoreboards on server switch

SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.

https://www.spigotmc.org/go/bungeecord

Other

1.57k stars 1.1k forks source link

Clear scoreboards on server switch #3503

Open andreasdc opened 1 year ago

andreasdc commented 1 year ago

Feature description

Players get kicked when you connect to the server with the same scoreboard names.

Goal of the feature

No kicks.

Unfitting alternatives

Tried setting unique names, but to achieve full protection you need to do it everywhere.

Checking

[X] This is not a question or plugin creation help request.
[X] This is a feature or improvement request.
[ ] I have not read these checkboxes and therefore I just ticked them all.
[X] I did not use this form to report a bug.

andreasdc commented 1 year ago

It creates huge problems, even with many checks to have unique names java.lang.IllegalArgumentException: Team 4168557420428d7f already exists in this scoreboard

md-5 commented 1 year ago

They are cleared: https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/ServerConnector.java#L264-L277

andreasdc commented 1 year ago

Currently I can't even join the server, it shows this error.

md-5 commented 1 year ago

Remove all scoreboards and scoreboard plugins. You likely have a broken scoreboard plugin

andreasdc commented 1 year ago

I sometimes get kicked when switching servers, are you sure that it works properly?

md-5 commented 1 year ago

I don't know - create a minimal reproduction (two new vanilla servers with same scoreboard names) and see