Open Outfluencer opened 8 months ago
With the introduction of skin data on tablist in minecraft 1.7, an eventual implementation of global tab lists got more complicated and was therefore not done.
global tablist was identical to global_ping, but without real ping display. global would show all players on bungee in tablist.
So should we maybe remove it completely or implement it?
i wanted to add it now, but i thought about and and i don't understand how it possibly works at all.
If someone with permissions enters vanish mode and is vanished for everyone but server team members.
How should i detect if i now have to add this player to the GLOBAL tablist or not cause maybe the player has permissions to see the vanished player on the backend server and maybe not,
Example Player1 enters Vanish on Lobby1, server sends remove Player to the players, onUpdate will handle it and remove him from global tablist, Player2 who has permissions to see Player1 joins the server onUpdate is called with add player and adds the player to everyones tablist even if he dont have permission to see Player1.
Was this taken into account when it was added before? If so, was there already a Vanish api in Spigot back then?
i wanted to add it now, but i thought about and and i don't understand how it possibly works at all.
If someone with permissions enters vanish mode and is vanished for everyone but server team members.
How should i detect if i now have to add this player to the GLOBAL tablist or not cause maybe the player has permissions to see the vanished player on the backend server and maybe not,
Example Player1 enters Vanish on Lobby1, server sends remove Player to the players, onUpdate will handle it and remove him from global tablist, Player2 who has permissions to see Player1 joins the server onUpdate is called with add player and adds the player to everyones tablist even if he dont have permission to see Player1.
Was this taken into account when it was added before? If so, was there already a Vanish api in Spigot back then?
Afaik it was not handled at all. With a global tablist, bungee would manage it, display everyone connected, and a separate bungee plugin would be needed to handle vanish, maybe those existed in the past using unsafe packet send or so.
Feature description
We should implement them or remove them completely, but what should they actually do? I dont really understand what GLOBAL(), GLOBAL_PING(), SERVER(); means, maybe someone can explain.
https://github.com/SpigotMC/BungeeCord/blob/1a807731a5ad8e8771d0254fd06296aea4f4dd31/proxy/src/main/java/net/md_5/bungee/conf/YamlConfig.java#L46
Goal of the feature
Remove this to get cleaner code or implement it so wo dont have unused enums and config options
Unfitting alternatives
.
Checking