SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.54k stars 1.1k forks source link

Integrate BungeeGuard for more safety out of the box #3592

Open mrjasonn opened 6 months ago

mrjasonn commented 6 months ago

Feature description

Integrating BungeeGuard will make BungeeCord safer. I advise that the BungeeCord team may want to work with the BungeeGuard team to integrate this. It can be considerable to make this toggle-able, but it should be turned on by default if toggle-able (should probably make it that). It can also be complicated to use the official suggestions to secure the server whilst making sure it is set up correctly to make sure everything works properly. So the request is for you to integrate BungeeGuard features into BungeeCord for safety and not have the hassle of installing another plugin to make the server safer easily. The features is to use a secure key that both the proxy and the backend server have to authenticate, making sure players are coming from the same proxy, not another impersonating proxy.

Goal of the feature

This will enhance the security of BungeeCord out of the box, so users can enjoy seamless server switching without the hassle of adding extra plugins just to secure the server easily.

Unfitting alternatives

This is just to improve the BungeeCord out of the box security, so this section would not be applicable.

Checking

Spigot issue tracker link: https://hub.spigotmc.org/jira/browse/SPIGOT-7559

Janmm14 commented 6 months ago

A similar feature request should be posted on spigotmc's issue tracker, bungeecord and spigot should do this hand-in-hand or shouldn't do it at all.

md-5 commented 6 months ago

You haven't actually explained what the request is

Janmm14 commented 6 months ago

You haven't actually explained what the request is

BungeeGuard is a plugin which adds some password to bungee's forwarding data and the spigot plugin makes sure the password is correct or else joining will be prohibited. not sure whether its plaintext password or some encryption used tho.

mrjasonn commented 6 months ago

You haven't actually explained what the request is

the request is for you to integrate BungeeGuard features into BungeeCord for safety and not have the hassle of installing another plugin to make the server safer easily.

md-5 commented 6 months ago

You haven't said what those features are

mrjasonn commented 6 months ago

You haven't said what those features are

The features is to use a secure key that both the proxy and the backend server have to authenticate, making sure players are coming from the same proxy, not another impersonating proxy.

mrjasonn commented 6 months ago

A similar feature request should be posted on spigotmc's issue tracker, bungeecord and spigot should do this hand-in-hand or shouldn't do it at all.

Apologise for not seeing this comment, but it has been done.

andrew121410 commented 5 months ago

BungeeGuard

Where is BungeeGuard located?, I was just thinking about this, I was about to just create a plugin for this, but I guess I don't have to lol.

Yeah, I wish Bungeecord just implemented this something, like what Velocity does

Edit: I found it at https://github.com/lucko/BungeeGuard

andrew121410 commented 5 months ago

But @md-5 if you look at the README of BungeeGuard plugin, it goes in more detail of what the problem is, and why it's necessary.