Possible unintentional functionality with "formatless" strings

[bob7l]

Bungeecord version

BungeeCord-Proxy 1.20-R0.3-SNAPSHOT ( build 1800)

Server version

No response

Client version

1.8, 1.20.2

Bungeecord plugins

None

The bug

Not sure if this is intended behavior, but if we readBaseComponent a String which has no format (example: 'asdasd'), the string will be given a default white color.

Upon being converted back to legacy text through toLegacyText(), the string will now contain the white format symbols at the beginning of the string therefor incrementing it's original length by 2

I managed to "fix" this by simply adding this check to verify the component actually has a set color:

void addFormat(StringBuilder builder) { if (!(!style.hasColor() && parent == null)) builder.append(getColor());

At BaseComponent's addFormat function

Log output (links)

No response

Checking

• [X] I am using BungeeCord and not a fork. Issues with forks should not be reported here.
• [X] I think this is not an issue with a bungeecord plugin.
• [ ] I have not read these checkboxes and therefore I just ticked them all.
• [X] This is not a question or plugin creation help request.

[Outfluencer]

i think you probably right

[Janmm14]

This implementation causes wrong results of toLegacyText(BaseComponent...). I updated my PR (mentioned above) with new context-aware toLegacyText implementations.