search

SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.57k stars 1.1k forks source link

Player are randomly kicked (Now we know why) #831

Closed ghost closed 8 years ago

ghost commented 10 years ago

I open this new issue only to see md5 watch that ! Now whe know why people were kicked, https://github.com/SpigotMC/BungeeCord/issues/786

"The issue occurs when a player is teleporting between a 1.7.2 generated chunk (or possibly a 1.6.4 one but with 1.7.2 items) and a 1.6.4 chunk or vice versa."

I'm sure it's the problem. Thank's for watching, and hope to see that working !

Bye.

externo6 commented 10 years ago

What am I watching? Managed to reproduce this, but only once :/

ghost commented 10 years ago

I said, i'm waiting for md-5.

SEAPUNK commented 10 years ago

@anonyme75 It'd be helpful if you could get others to confirm the issue and explain the issue further and etc, instead of "waiting for [so-and-so]". Don't put all the stress onto md_5, he's not the only guy that can help.

ryantheleach commented 10 years ago

Translation:

I have opened this new issue to alert md5 (in case he had muted) the already existing issue #786 where we believe we have discovered the cause of people getting kicked.

Thanks for reading.

ghost commented 10 years ago

Thank's @ryantheleach, i was very tired and i'm french... Have a nice day !

SEAPUNK commented 10 years ago

@ryantheleach thanks, that clears it up.

winglessraven commented 10 years ago

We suffer badly from this issue. Is anyone else still suffering?

Players get kicked on changing servers (bungee) and teleporting within one server. It's really hurting us now :(

ninja- commented 10 years ago

There is nothing that can be done about it :/ It's hard to reproduce, annoying and random but happens for me too D: I wonder if https://github.com/SpigotMC/BungeeCord/commit/37ed331515cbab7779270a73c12bccf5893b6aaa maybe fixed it? Can anyone reproduce it now after this commit ?

winglessraven commented 10 years ago

Ok... it's early days but we appear to have found a fix (fingers crossed).

After weeks of trying to figure out a common plugin across servers / ensure everything is up to date, testing packet loss etc. we finally (probably should have done this earlier) started removing plugins (bungee and server), the one thing that appears to have stopped the kicks is removing BungeeYAML (it was needed for our tab list). Like I say, early days, but so far, so good.

externo6 commented 10 years ago

We also have BungeeYAML, let us know if removing it continues fix the issue. BungeeYAML is no longer been developed: http://www.spigotmc.org/resources/bungeeyaml.14/

winglessraven commented 10 years ago

@externo6 Well, 24 hours on and we've seen a huge reduction in the number of kicks. I've spent hours traveling between our 10 servers and teleporting within them and have only had the same kick/crash twice. Massive improvement. Now to find what caused those two...

roblabla commented 10 years ago

roflmao. I'm the author of BungeeYAML, and I can say with proof that it doesn't directly cause this issue. BungeeYAML alone doesn't even execute any single piece of code, so how could it ? What happened is, you removed bungeeyaml, which broke a plugin that depends on it. @winglessraven i'd love to know which plugins you have installed on your bungeecord.

winglessraven commented 10 years ago

You're absolutely right, sorry I wasn't thinking straight when I posted that. The only plugin we have that depends on BungeeYAML is TabListPlus. Aside from that we only have one other bungee plugin that we coded for cross server chat channels etc. Removal of the TabList has reduced the crashes/kicks by a fair amount but it is still happening. We've updated everything possible and removed server plugins one by one and just cannot find what else is causing it. It's a pain in the ass to replicate so very difficult to troubleshoot. All I know is that it doesn't happen with rapid teleporting/server changing. Best way to try and reproduce is to wait 10 to 20 minutes before teleporting (cross server or within server) and BOOM bad packet kick. Server logs just show disconnect and client logs just show the kick message. So frustrating :(

roblabla commented 10 years ago

Can I get a list of plugins you currently have ? Also, does the issue happen when you have absolutely no plugins ? I'll try replicating your environment and use some magic to try and find the issue.

winglessraven commented 10 years ago

@roblabla Sure, plugins we have are below. I've tried to replicate locally without any plugins and cannot.

Bungee: BungeeTabListPlus (now removed), Nova Bungee

Hub: TeleportSigns, bPermissions, PlugMan, WorldEdit, CommandBook, SuperJump, Vault, Cinema, Multiverse-Core, BungeePortals, BarAPI, WorldGuard, Simple_Player_List, Spoof, SignColours, iConomy, cIP, NovaAnnouncer, TimeLock, Nova, VariableTriggers, NovaHub, FirstJoinPlus, ProtocolLib, SimpleCensor, CleanroomGenerator, MagicClock, Citizens, Multiverse-Portals, CompassNavigation, VanishNoPacket, EchoPet, Chairs, PlayEffect, CraftBook, Laser

Creative: TeleportSigns, PlugMan, WorldEdit, CommandBook, Heads, SuperJump, SimpleHelpTickets, PlotMe, LogBlock, BungeePortals, Easy_Spawn, WorldGuard, DiagonalBlocks, Simple_Player_List, CommandSyncBukkit, cIP, Nova, TeleportSuite, ProtocolLib, TabAPI, SimpleCensor, CleanroomGenerator, TabConfig, bPermissions, AsyncWorldEdit, Multiverse-Core, dynmap, WorldBorder, Multiverse-Portals

Minigames: TeleportSigns, bPermissions, PlugMan, WorldEdit, SignMod, CommandBook, Splegg, LobbySpawn, Vault, Cinema, Multiverse-Core, BungeePortals, WorldGuard, Simple_Player_List, Minigames, cIP, BomberCraft, PortalGun, CrackShot, Nova, SkyWars, TempleRun, ProtocolLib, SimpleCensor, CleanroomGenerator, ServerSigns, DisguiseCraft, PropHunt

Skyblock: bPermissions, PlugMan, WorldEdit, iConomy, cIP, SimpleAnnouncer, CommandBook, Nova, TeleportSuite, OpenInv, Vault, Multiverse-Core, BungeePortals, LWC, uSkyBlock, WorldGuard, SimpleCensor, Simple_Player_List, Multiverse-Portals, Multiverse-NetherPortals, ChestShop

PVP Hub: TeleportSigns, bPermissions, PlugMan, CommandSyncBukkit, WorldEdit, SignMagic, CommandBook, SimpleAnnouncer, Nova, LobbySpawn, Simple_Player_List, BanManager, Vault, Multiverse-Core, ProtocolLib, BungeePortals, BarAPI, WorldGuard, TabAPI, SimpleCensor, CleanroomGenerator, TabConfig, NovaAnnouncer, CompassNavigation, NovaPVP

PVP game servers: Citizens, bPermissions, NoCheatPlus, WorldEdit, CommandBook, Nova, ProtocolLib, BarAPI, NovaArena, WorldGuard, CleanroomGenerator, LibsDisguises, TagAPI

Towny: bPermissions, PlugMan, Inquisitor, FrameProtect, Websend, Vault, Cinema, SimpleHelpTickets, CommandTicks, Multiverse-Core, MCDocs, Spoof, dynmap, PerformanceMonitor, SQLibrary, KBPL, Fly, PointShop, Nova, TeleportSuite, OpenInv, BanManager, VariableTriggers, InfinityDispenser, ProtocolLib, Votifier, mcMMO, CleanroomGenerator, SimpleCensor, Citizens, HorseKeep, SBC, SimpleVoteListener, NovaDungeons, WorldEdit, Towny, Skript, Multiverse-Inventories, PaidSwitch, SimpleAnnouncer, VanishNoPacket, Heads, BetterShop, Sign_Casino_Blackjack, LogBlock, MyCommand, Questioner, EchoPet, StarHunter, ItemSlotMachine, Jail, Simple_Player_List, SignColours, HeroicDeathPlus, Lottery, Minigames, iConomy, cIP, Loot, SimpleCountDown, ClearLag, FirstJoinPlus, MonsterBox, IgnoreYou, CommunityBridge, WorldBorder, Orebfuscator, CommandSigns, Multiverse-Portals, Sign_Bank, CommandBook, Chairs, Register, DisguiseCraft, PlayerPoints, MobArena, TownyChat, VirtualPack, LWC, WorldGuard, MagicCarpet, HomeSpawnPlus, CraftBook, ChestShop, Dynmap-Towny, OtherDrops

ninja- commented 10 years ago

bPermissions, PlugMan, Inquisitor, FrameProtect, Websend, Vault, Cinema, SimpleHelpTickets, CommandTicks, Multiverse-Core, MCDocs, Spoof, dynmap, PerformanceMonitor, SQLibrary, KBPL, Fly, PointShop, Nova, TeleportSuite, OpenInv, BanManager, VariableTriggers, InfinityDispenser, ProtocolLib, Votifier, mcMMO, CleanroomGenerator, SimpleCensor, Citizens, HorseKeep, SBC, SimpleVoteListener, NovaDungeons, WorldEdit, Towny, Skript, Multiverse-Inventories, PaidSwitch, SimpleAnnouncer, VanishNoPacket, Heads, BetterShop, Sign_Casino_Blackjack, LogBlock, MyCommand, Questioner, EchoPet, StarHunter, ItemSlotMachine, Jail, Simple_Player_List, SignColours, HeroicDeathPlus, Lottery, Minigames, iConomy, cIP, Loot, SimpleCountDown, ClearLag, FirstJoinPlus, MonsterBox, IgnoreYou, CommunityBridge, WorldBorder, Orebfuscator, CommandSigns, Multiverse-Portals, Sign_Bank, CommandBook, Chairs, Register, DisguiseCraft, PlayerPoints, MobArena, TownyChat, VirtualPack, LWC, WorldGuard, MagicCarpet, HomeSpawnPlus, CraftBook, ChestShop, Dynmap-Towny, OtherDrops

86 plugins 2014

winglessraven commented 10 years ago

@ninja- Yeah I know xD It was our first server before we added hub etc so all of our 'core' players are there and enjoy the features. TPS is mostly always 20 and we are slowly removing from this list.

ninja- commented 10 years ago

hm confirmed in latest build :/

winglessraven commented 10 years ago

@ninja- What environment was it confirmed in? No plugins etc? Any idea what causes it?

ninja- commented 10 years ago

nope but I think it happened when two pending connections lagged and then switched the server at the same time...

ninja- commented 10 years ago

@md-5 I got an idea what could cause this... https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/ServerConnector.java#L136 ^ this happening two times without chunk packets in between or dimension switch coming when chunks are unloaded ???