SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.57k stars 1.1k forks source link

Kicked with outdated server when trying to connect with minechat. #843

Closed mibby closed 10 years ago

mibby commented 10 years ago

It seems users are being kicked with the outdated server message when trying to connect to the server with the minechat app. This started happening when upgrading BungeeCord to build 809. I presume this is caused by the dual protocol support.

literalplus commented 10 years ago

If it works fine in the Minecraft client, isn't that an issue of that App?

md-5 commented 10 years ago

Blame the app - its identifying itself as an unsupported Minecraft version. We support 1.7.2, 1.7.4 and the latest snapshot.

mibby commented 10 years ago

Thanks for informing. I'll forward the info to the users complaining about being kicked.

vbisbest commented 10 years ago

Hi, creator of MineChat here. I have had a few customers complain about this as well. Upon investigating, it appears that the server is not returning the correct protocol version when asked for the server information. Here the response for server information to a server running Spigot and BungeeCord (198.24.128.234:25934)

{"version":{"name":"1.7.4","protocol":8},"players":{"max":3000,"online":0},"description":"§b-\u003d§6TrueReality Networks§b\u003d-"}

The protocol is showing 8, when 1.7.4 uses protocol 4. Vanilla MC and Bukkit all return protocol 4 as it should. I dont know if Spigot is doing this or BungeeCord but hopefully someone here can figure that out and get it fixed. Thanks for your help!

Ray

Thinkofname commented 10 years ago

@vbisbest https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java#L178 Bungee sends back the protocol version you sent it if its listed as supported (4 and 8 currently) Minechat must be sending the wrong protocol version in the handshake

vbisbest commented 10 years ago

Thanks for the quick response @thinkofdeath . I see the issue. MineChat works with MC versions from 1.6.4 and up. It sends the ping request in the old format first with protocol 78 in case its a pre 1.7 server. Most all servers return protocol 127 if its 1.7 and up (MC Vanilla and Bukkit). But Spigot returns 8. It would be great if you could get Spigot to return the same as Vanilla MC with a 127. That would fix this issue. Thoughts?

literalplus commented 10 years ago

@vbisbest BungeeCord != Spigot

vbisbest commented 10 years ago

Thank you @xxyy I see. I will open a bug against BungeeCord and hopefully they can change it. Here is the line of code https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java#L138

Thanks for everyone's help! Ray

literalplus commented 10 years ago

@vbisbest this is BungeeCord. Spigot is http://github.com/SpigotMC/Spigot .

vbisbest commented 10 years ago

Opened new bug: https://github.com/SpigotMC/BungeeCord/issues/850