SpikeHD / AmazonMonitor

Amazon price checker, item monitor and stock monitor, all shoved into a Discord bot
GNU General Public License v3.0
235 stars 39 forks source link

add price difference threshold to avoid spamming messages #95

Closed kekkodance closed 1 year ago

kekkodance commented 1 year ago

10 cent price changes are useless

i also made the firefox UA more modern

...i can't figure out how to add this as a config parameter

SpikeHD commented 1 year ago

No need to nuke Jest, would much prefer just fixing the tests (which should be a seperate PR, if you're gonna do that) :P

I would also argue that the -p (pricelimit) option is enough here. If an item is regularly, say, $10, then you can just set a price limit of $9, if you don't care about it hitting $9.94, $9.87, etc.

kekkodance commented 1 year ago

but the item can wobble around in price and the -p option is then obsolete because for example we have an item that's 220 euro and i set a limit for 219, the item could slowly inch up and down (218, 219, 218.5) and still send notifications

SpikeHD commented 1 year ago

Sure, that makes sense. In that case it should be a per-item basis. Something similar to -p but for thresholds, like maybe -t, where each individual item has it's own optional threshold, instead of a single, static, global one.

kekkodance commented 1 year ago

could you help out with that? i didn't manage to make it a flag.

SpikeHD commented 1 year ago

You can close this and make a feature request issue instead, if you want, and I'll get to it sometime

SpikeHD commented 1 year ago

Added in rewrite