SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
628 stars 20 forks source link

[Bug] Auto update not working correctly #162

Closed Temanor closed 11 months ago

Temanor commented 11 months ago

Describe the bug When auto updator prompts you to restart, no update gets applied. It will just launch into the same version you already have, and give you the auto updator popup again.

To Reproduce Open an old Dorion 2.2.1 Click "Yes please!" when it asks if you want to apply new updates. Click "Yes" when Windows asks if you want to allow changes from unknown program Click "OK" when Dorion asks you to restart.

Expected behavior Dorion should restart with the latest version.

System Info:

Additional context Didn't look like there was anything done to fix this in the latest release, so I'm assuming it's broken in 2.3.0 as well, though that would be hard for me to test now

pacjo commented 11 months ago

It's also broken on linux (v2.2.1).

System info: Operating System: KDE neon 5.27 KDE Plasma Version: 5.27.9 KDE Frameworks Version: 5.112.0 Qt Version: 5.15.11 Kernel Version: 6.5.13-x64v3-xanmod1 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 2600 Six-Core Processor Memory: 15,5 GiB of RAM Graphics Processor: AMD Radeon RX 580 Series Manufacturer: Gigabyte Technology Co., Ltd. Product Name: B450M DS3H V2

GalaxinTM commented 11 months ago

Same issue here, Windows 11 23H2 I think I found the issue Failed to get release: Failed to get latest release from GitHub: error sending request for url (https://api.github.com/repos/SpikeHD/Dorion/releases/latest): error trying to connect: invalid URL, scheme is not http

SpikeHD commented 11 months ago

Apparently I just packaged an old version of the updater, and I've updated the binaries on the latest release to come with the right one hopefully

plutonium-239 commented 11 months ago

So do we need to download the new binary manually or will the auto updater take care of it?

SpikeHD commented 11 months ago

Given that the problem is, well, the updater, yes you'll need to download the new binary manually to get the fixed version, but future updates should work from then on.