SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
628 stars 20 forks source link

[Bug] Dorion version number in settings not showing up #164

Closed Temanor closed 10 months ago

Temanor commented 11 months ago

Describe the bug The dorion version number in the settings doesn't appear the first time you enter the settings after restarting, but does appear the second time.

To Reproduce press Ctrl+R Enter settings Scroll down to the bottom of the page

Expected behavior The Dorion version number should appear every time you enter the settings.

Screenshots Screenshot 2023-12-05 210342

System Info:

Additional context This was why I didn't see it when I reloaded 6 times, but appeared right away after I entered the settings to check once more after you sent the screenshot.

SpikeHD commented 11 months ago

Is this still happening on v3?

Temanor commented 11 months ago

Yes it is. example

Temanor commented 11 months ago

I tried figuring out what was causing this, and it seems like it is caused by my theme. I have no idea how this makes any sense, but removing it and restarting Dorion will show the version number like intended. Here is the theme if you would like to test: mocha.zip

Temanor commented 11 months ago

Forgot to mention, I did not test with other themes.

SpikeHD commented 11 months ago

I've made changes to how this works, is it still happening? Or is it really just the theme borking it?

(Shelter plugins are now pulled from the internet on the fly so you can just reopen/refresh and the change will apply)

Temanor commented 11 months ago

I'm not sure what was happening. Nor do I understand how the theme could be affecting this, but when I set the theme to none, it worked normally. I'm unable to test now, but will try to remember it tomorrow morning.

Temanor commented 11 months ago

Nevermind? I tried again today. Looks like it only happens with Vencord enabled. I think I might have had Vencord disabled after testing white screen issue mentioned in #139 and thought it was because of the theme.

SpikeHD commented 10 months ago

is this still happening?

Temanor commented 10 months ago

No. I believe it was fixed when you changed how Vencord was injected, not that long ago.