search

SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
574 stars 18 forks source link

[BUG] "Unsupported Browser" when trying to join a voice channel on Arch Linux #210

Open Daktyl198 opened 7 months ago

Daktyl198 commented 7 months ago

Describe the bug When trying to unmute/undeafen, I get the error "Unsupported Browser"

To Reproduce Steps to reproduce the behavior: Download PKGBUILD from the AUR, and modify it to use the latest version of Dorion (4.1.2 at time of writing) Install Dorion Open, and try to undeafen

Expected behavior App should undefen/unmute

Screenshots If applicable, add screenshots to help explain your problem. image

System Info (please complete the following information):

Additional context I know this was an existing bug here: #30, but that seems to have been caused by webkit2gtk not building with WebRTC by default. I have the latest version of the library on my system, so that shouldn't be an issue.

SpikeHD commented 7 months ago

Yea I had thought (at that time) that it was implemented properly, but it's still behind the flag even today. Nothing I can do til it's compiled in by default

cachejames commented 6 months ago

Yea I had thought (at that time) that it was implemented properly, but it's still behind the flag even today. Nothing I can do til it's compiled in by default

Facing the same issue on Ubuntu-Unity 22.04. Any updates for the RTC (web audio) support as of today? How can I stay up-to-date on this problem?

P.S. I read this issue and the other related one too, I'm aware of the underlying problem which is lack of official RTC support in the webkit2gtk package provided by Ubuntu's maintainers. That's OK, I'm prepared to wait for as long as it takes them to release an update that would enable this support. However, when that happens, I will simply run apt upgrade to get the RTC-enabled version of webkit2gtk, and... what's next? Will Dorion automatically pick it up and enable its call/video functionality? Or will I have to download some other version of Dorion which you guys would have released by then?

SpikeHD commented 6 months ago

In theory, once it's implemented, it'll be a feature that defaults to being enabled (just like all other major browsers ever), so Dorion shouldn't need to do anything special.

If it does happen to be a default-disabled feature, then Dorion will have to update to Tauri v2 in order to have up-to-date WebkitGTK bindings that expose the option to enable WebRTC manually. Either way, once the feature exists in WebkitGTK, it'll be the no. 1 prio in getting into Dorion however necessary.

cachejames commented 6 months ago

In theory, once it's implemented, it'll be a feature that defaults to being enabled (just like all other major browsers ever), so Dorion shouldn't need to do anything special.

If it does happen to be a default-disabled feature, then Dorion will have to update to Tauri v2 in order to have up-to-date WebkitGTK bindings that expose the option to enable WebRTC manually. Either way, once the feature exists in WebkitGTK, it'll be the no. 1 prio in getting into Dorion however necessary.

I'm looking at my package manager and I see two seemingly identical packages named libwebkit2gtk: image

Dorion uses the first one (4.0-37). Interestingly enough, the values in the Latest Version column are the same (2.42.5). Can you comment on this? Just out of curiosity, I'd like to understand the difference and why Dorion uses 4.0.37 and not 4.1.0

SpikeHD commented 6 months ago

I don't really know tbh, but a quick Google suggests that the difference between 4.0 and 4.1 packages is just that 4.0 is an older API. The version number that matters in regards to WebRTC support (as far as I'm aware) is the 2.42.5 one.

(Also, Tauri is migrating to the 4.1 API in v2, so Dorion shouldn't be on the old API for much longer than it takes for v2 to release)

CDzungx commented 6 months ago

@SpikeHD Maybe you can take a look at my fork and help me a bit for Tauri V2 im kindda struggled to migrate it but it do run on Windows now, without title bar 😂 and unfound bugs 😂😂

SpikeHD commented 6 months ago

Ahaha thank you, I appreciate the effort! The struggles you are facing are part of why I haven't bothered attempting the move yet (this, and v2 is still in beta) since there are sooo many breaking changes, but I'll try to remember to look sometime 👍

cachejames commented 2 months ago

Any updates on this issue?

On Thu, Mar 7, 2024 at 2:24 PM SpikeHD @.***> wrote:

I don't really know tbh, but a quick Google suggests that the difference between 4.0 and 4.1 packages is just that 4.0 is an older API. The version number that matters in regards to WebRTC support (as far as I'm aware) is the 2.42.5 one.

(Also, Tauri is migrating to the 4.1 API in v2 https://tauri.app/blog/2023/02/03/tauri-2-0-0-alpha-3/, so Dorion shouldn't be on the old API for much longer than it takes for v2 to release)

— Reply to this email directly, view it on GitHub https://github.com/SpikeHD/Dorion/issues/210#issuecomment-1984264797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3VJP5LFGENPNFADVMOCWLYXC5HFAVCNFSM6AAAAABDNW5W7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGI3DINZZG4 . You are receiving this because you commented.Message ID: @.***>

SpikeHD commented 2 months ago

I am working to port Dorion to Tauri v2 here, which will provide updated WebkitGTK bindings that expose the webrtc toggle option.

This does not mean Dorion will support it after this change, because WebkitGTK itself still does not distribute with WebRTC compiled in by default (it is a build-time flag). I think on NixOS they are working on providing a WebkitGTK with experimental features enabled? So that will probably be the first (and only) distro that supports it for a while.