SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
575 stars 18 forks source link

[Bug] Push to talk doesn't work correctly if you bind it to Alt #211

Open LeeseTheFox opened 7 months ago

LeeseTheFox commented 7 months ago

Describe the bug Push to talk doesn't work correctly if you bind it to Alt

To Reproduce

System Info

SpikeHD commented 7 months ago

Should be fixed as of 2e379cace5ba24c4a43ea9432c14865016bb7ef9, you are welcome to try an Actions build or just wait for the next release 👍

LeeseTheFox commented 6 months ago

Still not properly fixed in 4.1.3. If Dorion is your active window, the issue still occurs

LeeseTheFox commented 5 months ago

Not fixed 4.2.0

CDzungx commented 5 months ago

Seem to be tauri issue https://github.com/tauri-apps/tauri/issues/5327 isn't it?

SpikeHD commented 5 months ago

The global PTT is handled by the device_query crate, not Tauri, so this wouldn't be a Tauri issue

CDzungx commented 5 months ago

mine still working tho

SpikeHD commented 5 months ago

Last time I tried it worked fine for me too, unsure what the problem is (Windows 11 bug? I've only tested on 10)

LeeseTheFox commented 5 months ago

Last time I tried it worked fine for me too, unsure what the problem is (Windows 11 bug? I've only tested on 10)

I'm on W11. It's working fine when some other window is focused, but as soon as I click back on Dorion's window – it starts acting up

SpikeHD commented 5 months ago

Yea on W10 it works fine in both instances, so I'm really not sure ¯\_(ツ)_/¯

LeeseTheFox commented 5 months ago

Bug showcase: https://www.youtube.com/watch?v=wIq0iRmGBRI

SpikeHD commented 3 months ago

I like to hope this was fixed in the recent keybinds revamp of v5, let me know if it's still busted

LeeseTheFox commented 3 months ago

Still borked. Sometimes it fixes itself for a few moments, then goes back to broken again. Also now for some reason any push to talk key stops working when I click out of the window, but only if I'm using an installed Dorion client, Doesn't happen with portable version. Well, thanks for trying anyways. Maybe it's an issue somewhere on my end, we need someone else to test it on W11

SpikeHD commented 3 months ago

Double check that custom keybinds are enabled before testing global PTT specifically, it's not really clear but global PTT will not work without that enabled

writzx commented 2 months ago

Any chance to get scroll lock/num lock working for PTT? I use scroll lock for PTT by default. It's bound to my mouse.

Here's a few details which may be relevant:

SpikeHD commented 2 months ago

The crate used for backend key detection, device_query, doesn't detect ScrollLock apparently (you can Ctrl+F to look for all the different keys on that page).

I'd like to try a different key detection library but it's a bit of a pain to move to different ones, and they often also have keys they do not support. Maybe I can write a PR for it someday but it won't be terribly high on my priorities list

SpikeHD commented 2 months ago

A bit of digging tells me that a different input crate, inputbot, supports ScrollLock (and others), so I might make the move there, but switching input libraries requires a pretty big rewrite of the hotkey system, so I'll get to it eventually :tm: