SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
627 stars 20 forks source link

[Feature Request] Right click able to copy video media link (shelter mod) #239

Closed khewweifeng closed 1 month ago

khewweifeng commented 5 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently in Dorion, you can view image with left click and right click to copy image link but this does not apply for video media.

Describe the solution you'd like A clear and concise description of what you want to happen.

Able to copy video media link and paste to anywhere like official discord client

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Anything that can copy link into clipboard

Additional context Add any other context or screenshots about the feature request here.

Video didn't have the option to copy link, please refer to below attached photo.

image

SpikeHD commented 5 months ago

Edit: misunderstood what the screenshot was for lol sorry

BrennanAyers commented 5 months ago

I'm not entirely sure if it's how Dorion is handling the view, if something changed with Edge(?), or Discord itself changed how it works. What I do know is that it was working prior, and then I updated Dorion to 5.0.1 and it borked 🙃 It seems to be some sort of mismatch on how to handle right clicks, whether they're a Discord Context right click or a Web Browser Right Click. Discord Desktop: image Dorion: image Web Client (Firefox): image Upon checking all 3 I'm inclined to believe it's how the web client is set up now, which is probably worse and more unfortunate.

The loss of contextual menus can also be seen with URLs: Desktop: image Dorion/Web Client: image

And the text input box: Desktop: image Dorion/Web Client: image

Wondering if this functionality returning will have to fall to a plugin. Thanks. (realizing now the reason my previous version of Dorion was still working is because the client had been open for 2 weeks 🤣 )

SpikeHD commented 5 months ago

Great investigation! Yea, it looks like they differentiate now. It's especially evident since the menu items' actions pass a string that specifies web_:

image

Weird nerf tbh. This could probably be brought back in a plugin but I haven't taken a deep dive yet.

SpikeHD commented 5 months ago

Oh! Vencord has a plugin that does this already (and it's enabled by default iirc). Can probably just see what it does and reimplement it shelter style.

khewweifeng commented 5 months ago

Oh! Vencord has a plugin that does this already. Can probably just see what it does and reimplement it shelter style.

Thanks, I will use this first

BrennanAyers commented 5 months ago

oh, huh, I didn't see that plugin earlier. Thanks!

SpikeHD commented 1 month ago

I have gone over this again and the work involved to recreate something that already exists as a Vencord plugin doesn't feel worth my time. If someone else wants to make a Shelter-based context menu plugin, feel free to open a PR to add it as a default plugin in Dorion!