search

SpikeHD / shelter-plugins

Shelter plugins, some of them Dorion related
https://spikehd.github.io/shelter-plugins/
GNU General Public License v3.0
20 stars 5 forks source link

[Bug] Plugin Browser not working on Shelter MV2 v1.4 #26

Closed DeadLyBro closed 6 months ago

DeadLyBro commented 7 months ago

Describe the bug Plugin Browser not working on Shelter MV2 v1.4. It give error: Uncaught (in promise) ReferenceError: localStorage is not defined.

function U() {
            let e = localStorage.getItem("plugins-browser-cache"); // <-- here

To Reproduce Install: Plugin Browser > Refresh: Page > Open: User Settings > Scroll down and click Plugin Browser. It dropped error on Console.

Expected behavior Search and find Plugins on Github.

Screenshots image image image

System Info (please complete the following information):

Additional context

DeadLyBro commented 7 months ago

+ Idk why, it worked before but now its not working at Shelter latest version. (MV3 v1.2) bruh...

SpikeHD commented 6 months ago

This should hopefully be fixed in 8dca87e88fe5e126407916c21b9074679c9699fe, lemme know if it's still busted

DeadLyBro commented 6 months ago

image image

Uh, when I press preview, it say you rate-limited.

documentation_url: "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"
message: "API rate limit exceeded for IP ADRESS. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)"
SpikeHD commented 6 months ago

This isn't an issue with the plugin, the GitHub API is just ratelimiting you. Try again in a little while and it should work.

DeadLyBro commented 6 months ago

This isn't an issue with the plugin, the GitHub API is just ratelimiting you. Try again in a little while and it should work.

Ok, I will try some time later.