search

SpikeHD / shelter-plugins

Shelter plugins, some of them Dorion related
https://spikehd.github.io/shelter-plugins/
GNU General Public License v3.0
20 stars 5 forks source link

[Feature Request] Add INVITE_BROWSER support for shelteRPC #35

Closed Milkshiift closed 3 weeks ago

Milkshiift commented 3 months ago

Is your feature request related to a problem? Please describe. Currently, to accept an invite in a standalone client with shelteRPC you have to either log into Discord in a browser or send the link to a text channel in the client.

Describe the solution you'd like arRPC sends an "INVITE_BROWSER" command when a Discord invite link is accepted in a browser. ShelteRPC could join the guild when such message is received.

Additional context INVITE_BROWSER command would need to be implemented in rsRPC

SpikeHD commented 3 months ago

Prelim work is now done in rsRPC, surprisingly tough to find a good function to hook/flux event to use to respond on the Shelter plugin side though, so that's not done yet.

This will also not be compatible with regular arRPC because they don't send INVITE_BROWSER (and other non-activity) events to the browser, but if they add that then I will change rsRPC and ShelteRPC to match to keep feature parity 👍

SpikeHD commented 3 weeks ago

Along with some extra minor rsRPC fixes, this is now implemented in 48bfaa1882d0db6e4c31c3d15fe4da30eba3c36d!