search

SpikeHimself / XPortal

XPortal is a Valheim mod that lets you select a portal's destination from a list. XPortal is a complete rewrite of AnyPortal.
GNU General Public License v3.0
20 stars 6 forks source link

[Feature Request] Password Tag and More #58

Open rabrunos opened 1 year ago

rabrunos commented 1 year ago

Password TAG

The portal now has two TAG fields:

If the destination portal has a PASSTAG, then the origin portal must also have the same PASSTAG to be able to teleport to it.

portal

If the Destination Key field has some text and the destination portal has no password, this does not interfere to teleport! This allows to use the mod on a PvP focused server, where only those who know the password can teleport in my portal!

Remove Distance

Add an option in the configuration to remove the display of the distance between the portals so that it is not possible to know how many meters the user is from the other portal. (And that the configuration is enforced by the server configuration)

Show List on Enter

An option in the client-only configuration that when enabled makes it so that when you try to go through the portal, the list appears and then you press a button to teleport. That way I don't have to aim at the portal and press E every time I have to change the destination and I also don't accidentally teleport before selecting the destination.

SokBojowy commented 1 year ago

Big YES! for Password Tag. I created my account just to support this post. Great and very needed idea.

SpikeHimself commented 1 year ago

Hi, thank you for your support, and sorry for the extremely late response. Life's been very busy.

Password TAG

I have to give this a bit more time in my head. I'm unsure if adding a password is feasible, as you'd need a field to set a password as well as one where you enter it when selecting a new destination, and it will quickly get clunky. Also this would have to be an optional component to the UI, as not everyone will want this, so I have to redo some of the UI code for that too.

Remove Distance

The next XPortal update will include a config option HidePortalDistance which allows you to remove the distance indicator from the list of portals.

Show List on Enter

By 'Enter' do you mean entering the portal (i.e. walking into it)? I think that will quickly get annoying as most of the time you'd just want to travel. Maybe I misunderstood.

rabrunos commented 1 year ago

Yes, my suggestion is to show the list when you enter the portal. I understand that it can be annoying when you just want to travel! That's why I suggested it as an "option", so you can activate or deactivate it in the options, that way those who want the option active (like me) could just activate it! (It could be disabled by default!)

I completely understand about the password, as it would be a new system and you would have to change the UI. But it was just an idea and it would be interesting to have it in the mod, since there is no portal mod with this, it would be a totally unique mod. I hope you give this idea some thought :)

Sorry about the English, I try to say it in the best possible way using DeepL, as English is not my language! If you don't understand anything, let me know and I'll try to explain it better!

SpikeHimself commented 1 year ago

Yes, my suggestion is to show the list when you enter the portal. I understand that it can be annoying when you just want to travel! That's why I suggested it as an "option", so you can activate or deactivate it in the options, that way those who want the option active (like me) could just activate it!

Does this include portals that already have a destination configured? Or only for portals that don't have a connection yet?

If it is only for portals that aren't connected yet, then it is the same request as #63, which I think might be a nice addition.

If it's for all portals (connected or otherwise), I fear that, even though you say you do want this, you will inevitably end up annoyed by it, and so it's a lot of effort for nothing.

Additionally, with the request in #42 going live soon, you'll be able to immediately connect portals upon building them, which might clash with what you're asking.

rabrunos commented 1 year ago

I understand about the Default Portal feature. The 2 really can't work at the same time, unless "Default" was different from just checking a checkbox. If "Default" when active forces all portals to travel to it, then "Show on Enter" is not compatible.

There are only 2 ways for them to be compatible: 1 - There is another Default check, something like "Go To Default" active by default (not feasible). 2 - There are both options in the configuration to be activated, only one of which can be activated at the same time.

I can only see these solutions!

SpikeHimself commented 1 year ago

If "Default" when active forces all portals to travel to it

No, that is not how that feature will work. The Default Portal feature does not make you travel anywhere. It only initiates a connection with a portal, immediately upon building a new portal (so that you don't have to configure the portal first).

You still need to walk into the portal in order to travel.

Does that change how you envision your idea?

rabrunos commented 1 year ago

So if "Default" only serves to define the default connection between portals when the portal is built, then I don't see any compatibility problem. Because the player will only activate Show on Enter if he wants the benefits of this function.

Jester2020 commented 7 months ago

something similar to this would also solve my issue of simply wanting to have some portal be private and not show in the list.