SpikeHimself / XPortal

XPortal is a Valheim mod that lets you select a portal's destination from a list. XPortal is a complete rewrite of AnyPortal.
GNU General Public License v3.0
19 stars 6 forks source link

Advanced Portals not retaining 'name' and 'destination' info after logging out #70

Closed kmGaijin closed 11 months ago

kmGaijin commented 12 months ago

Describe the bug

To Reproduce

Expected behavior

LogOutput file(s)

Version

Priority

Additional information

From looking at the logs, the portals that show up in game with no 'name' or 'destination' actually look like they have info stored for them.

This portal is actually the BlackMarble Portal named 'gxplains' https://i.imgur.com/hpFAHaF.jpeg

This is the list when interacting with that portal. None of the advanced portals are listed, only the plain vanilla wood ones. https://i.imgur.com/utgWCM7.png

SpikeHimself commented 12 months ago

Hi @kmGaijin, thanks for reporting.

The cause of this is that along with the Hildir's Request update, Valheim changed the functionality that is used to retrieve all portals. This also created issue #59.

I think I can make a work-around for this, but it will be a big change. Ideally this should be fixed not by XPortal but by Advanced Portals. That mod needs to make sure that the Advanced Portals are returned by ZDOMan.instance.GetPortals()

SpikeHimself commented 12 months ago

It seems someone else has already run into this issue, see https://github.com/RandyKnapp/ValheimMods/issues/617

kmGaijin commented 12 months ago

Ah, thanks Spike.

SpikeHimself commented 11 months ago

Hi @kmGaijin, this issue has been solved by Advanced Portals, see: https://github.com/RandyKnapp/ValheimMods/issues/617#issuecomment-1734519824