SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
516 stars 186 forks source link

Conflict with ibl pykilosort with latest stable version of spikeinterface #1617

Closed carlacodes closed 1 year ago

carlacodes commented 1 year ago

Hi, while running a usual spike sorting job on my cluster I'm getting a new attribute error after upgrading to spikeinterface 0.97.1

\"/home/zceccgr/.conda/envs/ibl_pykil_ss/lib/python3.9/site-packages/spikeinterface/sorters/basesorter.py\", line 226, in run_from_folder\n    SorterClass._run_from_folder(sorter_output_folder, sorter_params, verbose)\n  File \"/home/zceccgr/.conda/envs/ibl_pykil_ss/lib/python3.9/site-packages/spikeinterface/sorters/external/pykilosort.py\", line 190, in _run_from_folder\n    run(\n  File \"/home/zceccgr/.conda/envs/ibl_pykil_ss/lib/python3.9/site-packages/pykilosort-ibl_1.4.2-py3.9.egg/pykilosort/main.py\", line 268, in run\n    rezToPhy(ctx, dat_path=dat_path, output_dir=output_dir)\n  File \"/home/zceccgr/.conda/envs/ibl_pykil_ss/lib/python3.9/site-packages/pykilosort-ibl_1.4.2-py3.9.egg/pykilosort/postprocess.py\", line 1480, in rezToPhy\n    _save('channel_labels', probe.channel_labels, np.int8)\nAttributeError: 'Bunch' object has no attribute 'channel_labels'\n",

env details: Python 3.9 (miniconda), pykilosort===ibl-1.4.2, spikeinterface==0.97.1

Has the channel_labels attribute been refactored/renamed recently?

Thanks.

alejoe91 commented 1 year ago

Hi @carlacodes

It's fixed in main, so it should be good with the next release. Currently you should downgrade pykilosort to ibl-1.4.2 or install spikeinterface from main ;)

carlacodes commented 1 year ago

Hi @alejoe91, realised it's a persistent error due to a typo in the actual spike sorter; my colleague submitted a pull request in January and thought it was already merged by now: https://github.com/int-brain-lab/pykilosort/pull/8