search

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
533 stars 187 forks source link

Bug in template.py since zarr handling #2469

Closed yger closed 9 months ago

yger commented 9 months ago

Line 210 and 277 in template.py are triggering errors on my machine, since the last push of zarr handling for Templates. The error is:

TypeError: unsupported operand type(s) for |: 'type' and 'type'

It can be removed if I remove the typing in the signatures of the function, since this is the str | Path that is problematic

h-mayorquin commented 9 months ago

This is most likely python 3.8 and 3.9 related. This should be solved after: https://github.com/SpikeInterface/spikeinterface/pull/2468

zm711 commented 9 months ago

I'll close this since with #2468 there is from __future__ import annotations everywhere now which should prevent any typing issues. Reopen if the issue wasn't solved.