SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
495 stars 188 forks source link

Spike sorting Error : attribute error due to `np.issctype' removed from Numpy 2.0 #3039

Closed taningh86 closed 2 months ago

taningh86 commented 2 months ago

Hi, This issue may be relevant to 'Support Numpy 2.0' issue opened by @h-mayorquin yesterday. Looks like np.issctype' was removed from Numpy 2.0 which is resulting in a spikesorting error. It says 'AttributeError:np.issctypewas removed in the NumPy 2.0 release. Useissubclass(rep, np.generic)` instead'. I tried to change it to 'issubclass(obj, np.generic)' but surprisingly the 'core' folder in spikeinterface folder is not there, therefore, no core_tools.py' file where I could make these changes. It surprised me because these files/folder are there in my personal laptop but cannot be found in the computer where I actually run analysis. The spikeinterface folder in the analysis computer only has two folders: postprocessing and qualitymetrics. When I updated SI some months ago I pulled it from github and I believe its doing automatic updates anytime there's an update or changes. However, if that's the case, it is still surprising that there are no other folder besides these two. Anyways, I will appreciate if you guys can guide me how to resolve this.

Thanks J

alejoe91 commented 2 months ago

That already takes care of the numpy issue

taningh86 commented 2 months ago

Ok. Thanks!

h-mayorquin commented 2 months ago

As there is a solution to this and it will be fixed in the upcoming release for dev as well I am closing this.