search

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
531 stars 188 forks source link

Auto-cast recording to float prior to interpolation #3415

Closed alejoe91 closed 2 months ago

alejoe91 commented 2 months ago

Fixes #3404

Thanks @jiumao2 for the suggestion

JoeZiminski commented 2 months ago

Is it worth printing / warning a statement when the conversion is done? Just to indicate the conversion is done and file will be larger if saved now.

alejoe91 commented 2 months ago

Is it worth printing / warning a statement when the conversion is done? Just to indicate the conversion is done and file will be larger if saved now.

Thanks @JoeZiminski

Since the correct_motion is intended to be as high-level as possible, we thought we would just keep it silent and do whatever's needed to avoid failures. @samuelgarcia @jiumao2 what do you guys think?

alejoe91 commented 2 months ago

Actually I'll just go ahead and merge..I think that an extra warnign will be confusing for most usere :)

jiumao2 commented 2 months ago

Since the correct_motion is intended to be as high-level as possible, we thought we would just keep it silent and do whatever's needed to avoid failures. @samuelgarcia @jiumao2 what do you guys think?

That's great! I’ve actually already added that code to my spikeinterface!