search

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
531 stars 188 forks source link

Add pip install requests to mountainsort4 install instructions #3431

Closed rly closed 2 months ago

rly commented 2 months ago

I just ran into the same issue as in #3367 and was quite puzzled. I think pip install requests should be included in the mountainsort4 installation instructions here in the spikeinterface docs.

rly commented 2 months ago

I also found that I needed to pip install pybind11 before mountainsort4 (which lists pybind11 as a requirement) on my Mac M1. I don't know how universal that is though.

zm711 commented 2 months ago

If I have time later today I can try on a Windows computer too and if it is necessary on Mac and Windows then I would say we should include pybind11 as a comment. Otherwise this looks good to me!

alejoe91 commented 2 months ago

I also found that I needed to pip install pybind11 before mountainsort4 (which lists pybind11 as a requirement) on my Mac M1. I don't know how universal that is though.

Yeah that is needed also on Linux. @rly could you add that too? Or @magland could add both to mountainsort4 :)

magland commented 2 months ago

@alejoe91

I have updated mountainsort4 to no longer depend on requests (and released to pypi) https://github.com/magland/mountainsort4/pull/9

As stated, it already has a requirement of pybind11... but I think that sometimes needs to be installed prior to ms4 installation.

rly commented 2 months ago

@magland released mountainsort4 1.0.6 which should resolve the need to install pybind11 as well. At least it does on my mac. Thanks!