search

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
531 stars 188 forks source link

Full test failing #3468

Closed zm711 closed 1 month ago

zm711 commented 1 month ago

@samuelgarcia @yger

FAILED src/spikeinterface/benchmark/tests/test_benchmark_sorter.py::test_SorterStudy - AssertionError

Sam let us know about the anarchy. Just so you both keep the testing in mind :)

yger commented 1 month ago

Arg damned. Anarchy is taking over, let's bring back order here @samuelgarcia this is related to your refactoring, I can try to have a look tomorrow.

samuelgarcia commented 1 month ago

sorry for that. I swear this was green when I merged it!

zm711 commented 1 month ago

Still failing on full tests. I don't know if this is a state issue with how our full tests are running, but same error is still present. I'll close once we see the tests pass. Maybe the commit hasn't made it into the full tests yet. If it is green today then we close otherwise this might need a bit of a deeper read. Let's see.