SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
531 stars 188 forks source link

Add custom tutorials index page. #3504

Closed JoeZiminski closed 2 days ago

JoeZiminski commented 4 weeks ago

This PR introduces a potential new way to index sphinx-gallery generated pages rather than using the default sphinx-gallery pages. This follows from discussions such as #2327 #2800, where it was discussed that having more flexibility to integrate sphinx-generated tutorials and non-sphinx generated .rst files in the same index page would be useful. At present, what is a tutorials vs. how to is arbitrarily fixed by how the documentation is built.

The approach taken here is to

The documentation is available here.

Some benefits of this approach:

Some drawbacks:

EDITS:

zm711 commented 4 weeks ago

Super busy day today so I'll give this a full read in the next couple days. I think this seems cool. I want to think about the concerns--adding css and html means that to contribute might become more daunting for the docs rather than a nice intro into the project so I'd like to think about looking good/dev preference vs inclusivity. But I'll do a full read soon :)

JoeZiminski commented 4 weeks ago

Thanks @zm711, looking forward to hearing your thoughts!

zm711 commented 4 weeks ago
Screenshot 2024-10-25 at 8 43 00 AM

Any way to fix this?

JoeZiminski commented 3 weeks ago

Hey @zm711, it might be through the sphinx machinery but I am not sure. This is an issue with the current live docs as well i.e. here but does not appear for the proposed custom index. I guess another benefit of the flexibility is we can directly troubleshoot such issues rather than having to work around the sphinx-gallery rendering.

JoeZiminski commented 3 weeks ago

Hi everyone, I think this is done from my end. The CSS / hover feature is removed, and some additional docs added to the developer documentation. We can merge as normal merge (not squash) to keep the CSS stuff in the git history in case it is useful to return to later.

JoeZiminski commented 1 week ago

@samuelgarcia @alejoe91 are you happy for this to be merged?

zm711 commented 6 days ago

We can ping them again early next week. I think this is nice so let's get this merged :)