Don't let decimate mess with times and skim tests

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.

https://spikeinterface.readthedocs.io

MIT License

531 stars 188 forks source link

Closed alejoe91 closed 2 weeks ago

alejoe91 commented 2 weeks ago

Deep bug in decimate, that deletes existing time vectors for segments!

This PR modifies the behavior so that time_vectors are also decimated, which is very intuitive.

Also skimmed a but the tests (previously 2100 tests with parameterized, now "only" 25)

zm711 commented 2 weeks ago

RTD has been so flaky. It has consistently failed on one of my Neo PRs for no reason....

alejoe91 commented 2 weeks ago

RTD has been so flaky. It has consistently failed on one of my Neo PRs for no reason....

Yeah we can look at that later..let me know if it looks good!