Spikeysanju / ZoomRecylerLayout

🎢 Zoom Recycler Layout Manager For Android Kotlin
814 stars 68 forks source link

Bug: sample is quite empty... #1

Closed AndroidDeveloperLB closed 4 years ago

AndroidDeveloperLB commented 4 years ago

I see this:

image

Spikeysanju commented 4 years ago

Hello, @AndroidDeveloperLB I think you have opened the wrong module(Which is an empty app which I create to test this Library.). Kindly check below link to open the library module. In which I have written the code for Zoom Recycler Layout. I hope it helps. Thanks a million! https://github.com/Spikeysanju/ZoomRecylerLayout/tree/master/zoomrecyclerlayout

AndroidDeveloperLB commented 4 years ago

I didn't. I cloned from here. Even the code shows it's empty:

image

Nothing special to show.

And your link too: https://github.com/Spikeysanju/ZoomRecylerLayout/blob/master/zoomrecyclerlayout/src/main/java/www/sanju/zoomrecyclerlayout/ZoomRecyclerLayout.kt

https://github.com/Spikeysanju/ZoomRecylerLayout/blob/master/app/src/main/java/www/sanju/zoomrecylerlayout/MainActivity.kt

Why close this issue?

Spikeysanju commented 4 years ago

@AndroidDeveloperLB I have clearly mentioned in the Readme below. That this is a Library and what is the step you have to do in implement this animation. It's a layout manager for recycler view. I hope you got my point.

Spikeysanju commented 4 years ago

For source code, you can see my another repo https://github.com/Spikeysanju/Tourism

AndroidDeveloperLB commented 4 years ago

Why put a repository with a launch-able app that doesn't do anything, instead of a sample to it, which actually use it and shows what's on the screenshots/animation?

At the very least, put a tiny sample.

As for the new link, even there I don't see a preview :

image

So here you put a nice preview but a sample that doesn't show anything, and there you put a sample that does something but no preview and barely even explanation about the repository...

Why 2 repositories anyway? In all repositories, people put both the library and the sample. One module for sample, and one for library...

And it's incorrect you said it's only the library here. You have a sample, so it should work.

Spikeysanju commented 4 years ago

Ok, will update this repo with sample code functionality!.

Have a nice day ; )

AndroidDeveloperLB commented 4 years ago

OK thank you! You are quick.

Spikeysanju commented 4 years ago

Thanks for your suggestion 😇