search

SpinGo / op-rabbit

The Opinionated RabbitMQ Library for Scala and Akka
Other
232 stars 73 forks source link

make code more Scala 2.13 friendly #172

Closed pjfanning closed 4 years ago

pjfanning commented 5 years ago

Some dependencies are not yet ready with scala 2.13 jars but these code changes get a lot of the way towards supporting scala 2.13.

Relates to https://github.com/SpinGo/op-rabbit/issues/171

pjfanning commented 5 years ago

@timcharper I think the jdk7 build fails in travis because sbt 1.2 doesn't appear to support jdk7 - is it necessary to continue jdk7 support?

dalmat36 commented 5 years ago

@pjfanning so you are able to get the 2.7.x version of Play JSON to work fine with op-rabbit without any changes?

When I add it as a dependency with the current 2.1.0 version it seems to cause my client to fail connecting.

pjfanning commented 5 years ago

@dalmat36 I am using https://github.com/pjfanning/op-rabbit in production. One difference is that my op-rabbit jars are built with play-json 2.7.4.

dalmat36 commented 5 years ago

Thanks @pjfanning I found my issue... it was unrelated to op-rabbit. play-json 2.7.4 works fine with the current version.

danslapman commented 4 years ago

Any news on this?

pjfanning commented 4 years ago

@danslapman I published a 2.13 compatible jar - https://github.com/pjfanning/op-rabbit#installation (I don't have commit/publish rights in this project)

timcharper commented 4 years ago

jdk7 is not necessary. Let's remove it from the config and get Travis green and we can merge / publish a new artifact

pjfanning commented 4 years ago

@timcharper com.spingo#scoped-fixtures_2.13;2.0.0 needs to be published if we want to support a scala 2.13 build -- https://github.com/SpinGo/scoped-fixtures/issues/2

timcharper commented 4 years ago

Can you please rebase this against the latest master? And remove CI changes?

pjfanning commented 4 years ago

@timcharper looks like circe 0.12 does not support scala 2.11 and older versions of circe do not support scala 2.13.

timcharper commented 4 years ago

@pjfanning I think it's probably ok to just drop 2.11 support right now. 2.12 has been out for a really long time and people have had ample time to upgrade.

timcharper commented 4 years ago

I've published scope-fixtures 2.0.0 for Scala 2.13