Don't use ExecutionContext.global. Improve `ackableFromFuture` to handle future exceptions.

SpinGo / op-rabbit

The Opinionated RabbitMQ Library for Scala and Akka

Other

232 stars 73 forks source link

Closed vic closed 4 years ago

vic commented 4 years ago

Never hardcode a global execution context since this could cause problems with users having a custom execution context. Let the user provide it via implicit arg.
ackableFromFuture now resolves with RecieveResult.Fail if the given future is a failure, just like it is done on ackableFromTry

vic commented 4 years ago

@timcharper, PR ready now :)