search

SpinW / spinw

SpinW Matlab library for spin wave calculation
http://www.spinw.org
GNU General Public License v3.0
37 stars 15 forks source link

Fix sw_issymspec to recognise powder spectra #146

Closed mducle closed 1 year ago

mducle commented 1 year ago

Quick fix for issue #145

mducle commented 1 year ago

In future we should consider:

  1. Converting the output spectra from a struct to a class with e.g. an is_sym property.
  2. Add consistency tests which run through the tutorials and check that they work (even if it doesn't check their outputs for correctness).
github-actions[bot] commented 1 year ago

Test Results

       4 files  ±0       98 suites  ±0   18m 30s :stopwatch: + 2m 10s    583 tests ±0     583 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 622 runs  ±0  1 622 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7b72927e. ± Comparison against base commit 12b0b45c.

:recycle: This comment has been updated with latest results.

RichardWaiteSTFC commented 1 year ago

In future we should consider:

  1. Converting the output spectra from a struct to a class with e.g. an is_sym property.

I think it should definitely be a class - should plotspec be a method?

  1. Add consistency tests which run through the tutorials and check that they work (even if it doesn't check their outputs for correctness).

I think we definitely need some form of doc-test like in mantid, but agreed just checking it doesn't error would be very helpful! Is it as easy as running .m files in this directory (with exception of publish_PSI.m)? https://github.com/SpinW/spinw/tree/df2a40d47cfc24a3bddb4fef82ec10c179fdabdb/tutorials/publish