search

SpinW / spinw

SpinW Matlab library for spin wave calculation
http://www.spinw.org
GNU General Public License v3.0
35 stars 15 forks source link

updates to multidimensional histo writer #166

Closed granrothge closed 6 months ago

granrothge commented 7 months ago

This updates the writing of spec to MDH file writer. So now the output along the x axis is scaled to the proj vector along it's direction rather than the norm of that vector this means a cut 0,0,0 to 1,1,0 would read 0 to 1 along the x axis rather than 0 1.41.
also a bug was fixed so it no properly writes things when q0 is something other than 0,0,0.

The tests were updated accordingly to ensure this bug is captured.

granrothge commented 7 months ago

@mducle @RichardWaiteSTFC Hi guys I caught a bug in my MDH writer that did not handle the case where the cut started from something other than 0,0,0. also I improved the axis scaling. let me know if you have any comments.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (950ad3b) 40.51% compared to head (ec22175) 40.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ========================================== + Coverage 40.51% 40.52% +0.01% ========================================== Files 240 240 Lines 15981 15985 +4 ========================================== + Hits 6474 6478 +4 Misses 9507 9507 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

granrothge commented 6 months ago

This should be good to go now.