search

SpinaCMS / Spina

Spina CMS
http://www.spinacms.com
Other
2.19k stars 403 forks source link

Fix account test #1272

Closed vanillaHafer closed 1 year ago

vanillaHafer commented 1 year ago

Context

On a recent PR for adding ancestry into custom_pages, there was a failing test.

Changes proposed in this pull request

These changes are to fix that test, and add a default setting for the Page factory

Bramjetten commented 1 year ago

It still fails?

mattpolito commented 1 year ago

@Bramjetten The introduced failure has been addressed, this a webdriver failure. That seems to be intermittent as I've seen it in previous commits. You may want to force a re-run. Seems like we have a lot of flickers.

As far as the current failure, it looks like webdriver is looking for a chromedriver version (115.0.5790) that is not listed on the chromiums version page.

vanillaHafer commented 1 year ago

The "flicker" around the first test failing was due to comparing Page objects and their json_attributes not being guaranteed to be in the same order. I handled that by just comparing object ids.

The 2 most recent test fails are due to the web driver issue.

Bramjetten commented 1 year ago

I'm also seeing intermittent web driver issues on other projects. Looks like something changed over there.