search

SpinaCMS / Spina

Spina CMS
http://www.spinacms.com
Other
2.19k stars 405 forks source link

Use left_outer_joins for NavigationItem scopes - Fixes #1294 #1297

Closed Bramjetten closed 1 year ago

Bramjetten commented 1 year ago

Because of the addition of custom URLs in NavigationItems, scopes on NavigationItem should use left_outer_joins(:page) instead of joins(:page).

Also, it doesn't make sense to use the regular_pages scope in the MenuPresenter.

Bramjetten commented 1 year ago

@aseroff Can you check if this fixes your issue?

aseroff commented 1 year ago

Hole in one again!