search

SpinaCMS / Spina

Spina CMS
http://www.spinacms.com
Other
2.2k stars 408 forks source link

Add a with_library_path scope to Attachable #1380

Open MSchmidt opened 4 months ago

MSchmidt commented 4 months ago

Context

I'm working on markdown support for Spina. To show images from the library I want them to be included with this easy syntax: ![Alt](foldername/imagename) within the markdown.

Changes proposed in this pull request

This scope on Attachable helps to fetch the right images based on that syntax.

Guidance to review

Right now Spina doesn't use this scope internally. So I can see how this might not be accepted at the time. Also it's still using ILIKE because that's what the main branch does. Will change it once you merge the sql PR.

Bramjetten commented 4 months ago

That's really really cool! Are you also looking at including a Markdown-editor (with preview?).

Really like the folder syntax.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bramjetten commented 1 month ago

Not stale!

how would House (MD) fit into this?

MSchmidt commented 1 month ago

House is not released yet, but I guess as trix alternative for the MD Parts it would work great. We'd need to expend it with an spina image picker though. This PR is only the preparation for that.