search

SpinaCMS / Spina

Spina CMS
http://www.spinacms.com
Other
2.19k stars 405 forks source link

Several translation issues #277

Closed elmo closed 2 years ago

elmo commented 7 years ago

I'm seeing various translation missing type errors throughout. I'm wondering if I somehow missed a configuration step?

screen shot 2017-07-14 at 9 44 17 am

ActionView::Template::Error (translation missing: en.spina.photos.delete): 1: .item 2: .overlay 3: = link_to spina.admin_photo_path(photo), method: :delete, class: 'icon-only delete-photo-link', data: {confirm: t('spina.photos.delete_confirmation')} do 4: = t('spina.photos.delete') 5: %span.photo-name= truncate(photo.name, length: 125) 6: = radio_button_tag :photo_id, photo.id 7: = check_box_tag 'photo_ids[]', photo.id

Bramjetten commented 7 years ago

It’s true that not all translations were updated during our refactoring. I’d advise to not raise exceptions on missing translations though.

elmo commented 7 years ago

Okay, thanks. Will do.

sdmoko commented 7 years ago

Hi @Bramjetten i'd like to add Indonesian Translation.

Bramjetten commented 7 years ago

@sdmoko Feel free to do so, it's best to use English as the base language since it contains all keys.

Mickey248 commented 6 years ago

i'd like to add thai Translation.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.