search

SpinaCMS / Spina

Spina CMS
http://www.spinacms.com
Other
2.19k stars 405 forks source link

Media Picker modal doesn't reopen if closed without choosing an image #726

Closed corporealfunk closed 3 years ago

corporealfunk commented 3 years ago

When I click "Choose Image" from the Spina::Image part UI from a page, the media picker modal opens. If I do not choose any images, and instead press "ESC" or click outside of the modal area, the modal closes.

However, if click again on "Choose Image", the modal does not open again.

(If I click on "Choose Image" on a different Spina::Image the modal will open for that target. And then the first target is valid again.)

media_picker_bug

silva96 commented 3 years ago

@Bramjetten just to be clear, this "fix" actually didn't fix the problem of visiting same url within the same turbo frame so now you have to manually set src to null?

Bramjetten commented 3 years ago

@silva96 Correct. You can never visit the same GET url twice on a turbo frame as of right now.

silva96 commented 3 years ago

It's crazy how many hours I thought I was doing something wrong, but actually the bug wasn't fixed at all in beta-7, everyone who reads that issue would thing it's solved and they have the problem for other reason

Bramjetten commented 3 years ago

Same here. It’s not a bug though, apparently this is how it’s designed.