search

SpineEventEngine / core-java

The Java implementation of the framework core
https://spine.io
Apache License 2.0
36 stars 12 forks source link

Do not allow internal types sent from client-side #1465

Closed alexander-yevsyukov closed 2 years ago

alexander-yevsyukov commented 2 years ago

This PR extends the client-side implementation with prohibiting sending types marked with internal_type option.

Such types are meant to be used only within a bounded context which declares it. Thus, sending them to the context from a client should not be allowed.

This PR also fixes the hierarchy of ClientRequest types by introducing ClientRequestBase. Previous implementation leaked unwanted API into the classes that were derived from ClientRequest (and now are derived from ClientRequestBase).

codecov[bot] commented 2 years ago

Codecov Report

Merging #1465 (9fcb7b7) into master (ac43c82) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1465   +/-   ##
=========================================
  Coverage     91.39%   91.40%           
- Complexity     4985     4986    +1     
=========================================
  Files           628      629    +1     
  Lines         15387    15393    +6     
  Branches        894      894           
=========================================
+ Hits          14063    14070    +7     
  Misses         1017     1017           
+ Partials        307      306    -1