search

SpineEventEngine / core-java

The Java implementation of the framework core
https://spine.io
Apache License 2.0
36 stars 12 forks source link

More internal type filtering #1471

Closed alexander-yevsyukov closed 2 years ago

alexander-yevsyukov commented 2 years ago

This PR teaches QueryService and SubscriptionService to reject calls referring types marked as internal_type (either directly in a type option or via a file option internal_all).

To extract common logic of processing, an abstract ServiceDelegate class was introduced. CommandService, QueryService, and SubscriptionService were modified to processing calls to classes derived from ServiceDelegate.

Also UnknownEntityTypeException was renamed to UnknownEntityStateTypeException to better reflect the cause of the error.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1471 (57eafa1) into master (b6fccad) will increase coverage by 0.00%. The diff coverage is 96.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1471 +/- ## ========================================= Coverage 91.39% 91.40% + Complexity 5012 5006 -6 ========================================= Files 631 632 +1 Lines 15402 15424 +22 Branches 887 882 -5 ========================================= + Hits 14077 14098 +21 Misses 1019 1019 - Partials 306 307 +1 ```
alexander-yevsyukov commented 2 years ago

@yevhenii-nadtochii, since you were the author of (#1449), you may want to have a look at this PR.