SpineEventEngine / core-java

The Java implementation of the framework core
https://spine.io
Apache License 2.0
36 stars 12 forks source link

Make Storage API and implementation more friendly to Spine's storage-specific libraries #1533

Closed armiol closed 10 months ago

armiol commented 1 year ago

This PR addresses some inconsistencies in both Storage API and its base/abstract implementation, so that descendant port libraries, such as Spine RDBMS could migrate their features to Spine 2.x with less hassle.

Major breaking change (breaking for SPI users, that is) is merging EntityRecordSpec and MessageRecordSpec into a single RecordSpec type. It has been done for several reasons.

Other changes include:

armiol commented 1 year ago

@alexander-yevsyukov PTAL.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1533 (e4ca6ea) into master (349fc83) will decrease coverage by 0.08%. The diff coverage is 96.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1533 +/- ## ============================================ - Coverage 89.90% 89.83% -0.08% + Complexity 5057 5025 -32 ============================================ Files 648 645 -3 Lines 15806 15751 -55 Branches 925 920 -5 ============================================ - Hits 14211 14150 -61 - Misses 1269 1274 +5 - Partials 326 327 +1 ```
armiol commented 10 months ago

@alexander-yevsyukov it has been a long time since this PR was first approved. Many things have changed since then. PTAL again.

armiol commented 10 months ago

@alexander-yevsyukov while reviewing the ... .storage package, I have also addressed some minor documentation issues, killed some unused methods, and commented on warnings.

And considering @SPI-ness, I have added an explicit test for RecordWithColumns API.

armiol commented 10 months ago

@alexander-yevsyukov PTAL.