SpineEventEngine / logging

Multiplatform fluent logging API for Kotlin projects
0 stars 0 forks source link

Enable back Java linters #56

Open yevhenii-nadtochii opened 1 year ago

yevhenii-nadtochii commented 1 year ago

I've temporarily disabled Java linters for some modules that contain not migrated Flogger code.

It is quite safe because our modules are in Kotlin, and not migrated code is the only code in Java.

They are disabled in the build files. It may be that all three (PMD, CheckStyle, ErrorProne) are disabled, or some of them.

Here is an example:

    /**
     * Disables Java linters until main sources are migrated to Kotlin.
     *
     * As for now, they produce a lot of errors/warnings to original
     * Flogger code, failing the build.
     */
    tasks {
        named("checkstyleMain") { enabled = false }
        named("pmdMain") { enabled = false }
        compileJava { options.errorprone.isEnabled.set(false) }
    }

Please, go through the modules and turn them back by removing this piece of configuration when the migration to Kotlin is completed.