SpineEventEngine / validation

Apache License 2.0
2 stars 0 forks source link

Start adopting Validation codegen #107

Closed alexander-yevsyukov closed 10 months ago

alexander-yevsyukov commented 10 months ago

This PR is the first of the seria brining code-generation of validation to life.

Here's the sequence of changes that we made in relation to this:

  1. The validation codegen was turned on via removing skipValidation() calls in build files.
  2. Several issues in codegen were discovered.
  3. The issues were fixed and tested via local deployment of Validation library and subsequent update and local deployment of McJava.
  4. Then, the skipValidation() was turned back on, and McJava version rolled back to 2.0.0-SNAPSHOT.170, so that we can build it at GitHub.
  5. This, of course, resulted in usage of older code of Validation, which required to disable tests that were written for newer validation code.

Further actions

Other notable changes

codecov[bot] commented 10 months ago

Codecov Report

Merging #107 (1528168) into master (6d3b46b) will decrease coverage by 4.02%. The diff coverage is 10.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #107 +/- ## ============================================ - Coverage 46.04% 42.02% -4.02% + Complexity 463 413 -50 ============================================ Files 124 123 -1 Lines 2543 2434 -109 Branches 199 196 -3 ============================================ - Hits 1171 1023 -148 - Misses 1321 1355 +34 - Partials 51 56 +5 ```