SpineEventEngine / validation

Apache License 2.0
2 stars 0 forks source link

Move `base/validate` to Validation #44

Closed armiol closed 1 year ago

armiol commented 1 year ago

This changeset moves base/validate module to this repository under java-runtime-bundle name.

Obsolete runtime and runtime-extensions modules are removed.

Also, all dependencies to mc-java now use its fat JAR (partially addressing mc-java#53).

Other changes include the updates to config contents: new Gradle version, updated Kotlin, etc.

codecov[bot] commented 1 year ago

Codecov Report

Merging #44 (cebc73b) into master (85b122d) will increase coverage by 36.52%. The diff coverage is 90.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #44 +/- ## ============================================= + Coverage 9.02% 45.54% +36.52% - Complexity 46 456 +410 ============================================= Files 62 117 +55 Lines 1463 2580 +1117 Branches 129 210 +81 ============================================= + Hits 132 1175 +1043 - Misses 1317 1360 +43 - Partials 14 45 +31 ```
armiol commented 1 year ago

@alexander-yevsyukov PTAL.

alexander-yevsyukov commented 1 year ago

@armiol, why do we need the bundle suffix in this case?

armiol commented 1 year ago

@alexander-yevsyukov we need this suffix to distinguish this artifact from the one with the same name we used previously. "Old" java-runtime was a completely different beast. And it has its versions published as well. I don't want new artifact to make an impression that it is the same thing as the "old" one.

Besides, with this suffix it is totally clear it is a fat JAR assembly. I could use "fat" instead, but it seems a bit of a jargon. "Bundle" looks more official to me.

alexander-yevsyukov commented 1 year ago

@armiol, got it. Agreed.