SpineEventEngine / validation

Apache License 2.0

3 stars 0 forks source link

Consider group valid if `(is_required)` set to `false` #55

Closed alexander-yevsyukov closed 2 years ago

alexander-yevsyukov commented 2 years ago

This PR: 1) Changes the structure of the project renaming Java-related modules to reside under the java-tests subproject. 2) Adds tests for vanilla-java code generation (under the new module called vanilla). 3) Fixes the edge case when the option (is_required) is present but set to false.

It also carries out the test for (goes_with), but its full satisfaction is left to the one of the following PRs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (3da0d90) into master (293dff2) will decrease coverage by 0.03%. The diff coverage is 7.69%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #55 +/- ## ============================================ - Coverage 43.89% 43.85% -0.04% Complexity 451 451 ============================================ Files 122 122 Lines 2654 2654 Branches 211 212 +1 ============================================ - Hits 1165 1164 -1 - Misses 1443 1444 +1 Partials 46 46 ```

alexander-yevsyukov commented 2 years ago

@armiol, оно-то сейчас билдится. Но используется версия валидации, которая встроена в ProtoData. А как заставить работать ту, что сейчас в разработке в таком варианте, я пока придумать не могу.

alexander-yevsyukov commented 2 years ago

@armiol, посмотрел в сгенерированный код модуля consumer, там работает — буду разбираться.

alexander-yevsyukov commented 2 years ago

@armiol, посмотрел в сгенерированный код модуля consumer, там работает — буду разбираться.

Заработало. build.gradle.kts случайно вложил под src.