search

SpineEventEngine / validation

Apache License 2.0
3 stars 0 forks source link

Bump `base` etc. #65

Closed alexander-yevsyukov closed 2 years ago

alexander-yevsyukov commented 2 years ago

This PR:

There are some MakeTestFilterHappyTest.java files in this change set. They are needed because of this issue.

alexander-yevsyukov commented 2 years ago

Pardon, does not see Kotlin DSL at CI again.

codecov[bot] commented 2 years ago

Codecov Report

Merging #65 (cba7c78) into master (6456b58) will decrease coverage by 0.18%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ============================================ - Coverage 43.85% 43.66% -0.19% + Complexity 451 447 -4 ============================================ Files 122 122 Lines 2654 2654 Branches 212 212 ============================================ - Hits 1164 1159 -5 - Misses 1444 1446 +2 - Partials 46 49 +3 ```
alexander-yevsyukov commented 2 years ago

@armiol, @dmdashenkov, I had to rollback usage of Kotlin proto-DSL because it breaks compilation at CI (and locally, if you make a pause between clean and build).

This time it doesn't find DSL code which is part of ProtoData compiler artifact. The code is there. Why it's not visible to the Kotlin compiler in some circumstances is a mystery to me.

Anyway, PTAL.

armiol commented 2 years ago

@alexander-yevsyukov this whole story with DSL is weird to me. Not much changed in our codebase, and yet such a thing was never observed on CI previously. Can it be caused by some unfinished business in the Gradle nightly build that we started using everywhere recently?

Just out of curiosity, let's also try the latest nightly build (see https://gradle.org/release-nightly/).

armiol commented 2 years ago

@alexander-yevsyukov OK, I see that you are using the latest nightly build already. Maybe, that's what breaks stuff? Let's try rolling back to the previously used nightly build (the one we started to use first). Also, if we have any Gradle cache enabled at CI, let's disable it in the scope of GH Actions pipeline.

alexander-yevsyukov commented 2 years ago

OK, I see that you are using the latest nightly build already.

I switched to this version in the hope that it's fixed by the latest Gradle code. I can switch back, but I've already tried many different nightbuilds of Gradle when trying to solve this issue in ProtoData. It didn't work.

I guess I need to have a closer look at how we filter KotlinCompile task input in ProtoData. There should be something wrong there.