SpineEventEngine / validation

Apache License 2.0

2 stars 0 forks source link

Extract `fatJar` publishing #73

Closed alexander-yevsyukov closed 1 year ago

alexander-yevsyukov commented 1 year ago

This PR:

Extracts publishing of fatJar artifact into fat-jar scripting plugin.
Extends spinePublishing with the ability to handle custom publications, introducing modulesWithCustomPublishing property.
Applies Gradle Shadow plugin at buildScript/.../build.gradle.kts level so that fat-jar script plugin is possible.

The version is set to 2.0.0-SNAPSHOT.60 to jump over 5x artifacts that were not successfully published because of errors in the previous PRs.

Once this PR is merged and new publishing is fully tested, the extensions introduced in this PR to common publishing schema would be added to config.

codecov[bot] commented 1 year ago

Codecov Report

Merging #73 (11a45bf) into master (0a4fa64) will not change coverage. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #73 +/- ## ========================================= Coverage 43.53% 43.53% Complexity 442 442 ========================================= Files 122 122 Lines 2653 2653 Branches 213 213 ========================================= Hits 1155 1155 Misses 1449 1449 Partials 49 49 ```

armiol commented 1 year ago

@alexander-yevsyukov Something isn't right. The module in master is already renamed, as far as I can see.

Also, if the name of the module is the same as the name of its fat JAR (and the fat JAR has no classifiers), their publishing will not be deterministic. In some cases, pom.xml of "small" artifact will overwrite the same file which belongs to "fat" artifact.

alexander-yevsyukov commented 1 year ago

@armiol, PTAL. I how now it should work. At least, publishing to mavenLocal() does without issues.

alexander-yevsyukov commented 1 year ago

LGTM. Not sure I understand how it works, but in any case the code became cleaner.

@armiol, I have added more documentation, and changed layout of code a bit. Does it make it a bit easy to understand? I suppose, we are going to use this kind of thing in other projects (we do a similar thing in mc-java already). So, it's better to make it easy to understand now.

alexander-yevsyukov commented 1 year ago

@dmdashenkov, PTAL too.