search

SpineEventEngine / validation

Apache License 2.0
2 stars 0 forks source link

Update ProtoData and include dependencies in the type system #84

Closed dmdashenkov closed 1 year ago

dmdashenkov commented 1 year ago

In this PR we make the validation's type system know about the module's dependencies. For that, we source info from the ProtobufDependency view.

We also make the runtime routine that unpacks Anys check if the type is known or now. If the type packed into the Any is unknown, the message is not validated and a warning is logged.

Also, fixes #69.

codecov[bot] commented 1 year ago

Codecov Report

Merging #84 (4ec4f7e) into master (28846fc) will decrease coverage by 0.08%. The diff coverage is 21.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #84 +/- ## ============================================ - Coverage 43.51% 43.43% -0.08% - Complexity 442 444 +2 ============================================ Files 122 122 Lines 2652 2673 +21 Branches 213 217 +4 ============================================ + Hits 1154 1161 +7 - Misses 1449 1463 +14 Partials 49 49 ```
dmdashenkov commented 1 year ago

@armiol, @alexander-yevsyukov, PTAL.

dmdashenkov commented 1 year ago

@armiol, PTAL.