SpineEventEngine / validation

Apache License 2.0
3 stars 0 forks source link

New ProtoData and annotated `Builder` methods #86

Closed dmdashenkov closed 1 year ago

dmdashenkov commented 1 year ago

In this PR we update the version of ProtoData to 0.9.1.

Also, we apply the new capabilities of ProtoData to annotate build() and buildPartial() methods with @Validated and @NonValidated respectively.

codecov[bot] commented 1 year ago

Codecov Report

Merging #86 (8eaf708) into master (0cb0153) will increase coverage by 1.81%. The diff coverage is 50.00%.

:exclamation: Current head 8eaf708 differs from pull request most recent head ad35e71. Consider uploading reports for the commit ad35e71 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ============================================ + Coverage 43.43% 45.25% +1.81% - Complexity 444 461 +17 ============================================ Files 122 123 +1 Lines 2673 2674 +1 Branches 217 217 ============================================ + Hits 1161 1210 +49 + Misses 1463 1406 -57 - Partials 49 58 +9 ```
sonatype-lift[bot] commented 1 year ago

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/SpineEventEngine/validation/86.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/SpineEventEngine/validation/86.diff | git apply

Once you're satisfied, commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.

dmdashenkov commented 1 year ago

@armiol, PTAL. Please note that most of the changes are just the updates of config, not actual repository code changes.

dmdashenkov commented 1 year ago

@armiol, PTAL.

armiol commented 1 year ago

@dmdashenkov please update the PR description with the new version. I will be reviewing the PR itself tomorrow.