search

SpineEventEngine / validation

Apache License 2.0
2 stars 0 forks source link

Performance improvements #93

Closed dmdashenkov closed 1 year ago

dmdashenkov commented 1 year ago

In this PR we make the validation's insertion points repeated. This reduces the number of operations required to lookup insertion points' desired positions and improves performance.

For further build time speed up, we add an extra level of caching for the Roaster's model to avoid unnecessary code parsing.

Also, config is updated.

dmdashenkov commented 1 year ago

@armiol, you may now take this branch and run your performance tests with it. On my local machine, the BuildSpeed time is now ~2:02 minutes, compared to ~4 minutes before the insertion point optimizations.

dmdashenkov commented 1 year ago

@armiol, PTAL. The build is failing at the moment because of a JaCoCo issue, unrelated to the core idea of the PR. Will be resolved later (before the merge).

codecov[bot] commented 1 year ago

Codecov Report

Merging #93 (c545ac8) into master (36055b6) will increase coverage by 0.14%. The diff coverage is 31.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ============================================ + Coverage 45.25% 45.39% +0.14% - Complexity 461 470 +9 ============================================ Files 123 124 +1 Lines 2674 2683 +9 Branches 217 208 -9 ============================================ + Hits 1210 1218 +8 - Misses 1406 1411 +5 + Partials 58 54 -4 ```