search

SpineEventEngine / validation

Apache License 2.0
3 stars 0 forks source link

Move `TypeSystem` to ProtoData #96

Closed dmdashenkov closed 1 year ago

dmdashenkov commented 1 year ago

In this PR we migrate Validation to the new ProtoData. The TypeSystem util is replaced with the generalized one from ProtoData.

Also, renderers and plugins are updated to match the new ProtoData API and guidelines.

codecov[bot] commented 1 year ago

Codecov Report

Merging #96 (3ac1251) into master (ebbcbd9) will increase coverage by 0.80%. The diff coverage is 0.00%.

:exclamation: Current head 3ac1251 differs from pull request most recent head 0ad5aa1. Consider uploading reports for the commit 0ad5aa1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #96 +/- ## ============================================ + Coverage 45.33% 46.13% +0.80% + Complexity 472 463 -9 ============================================ Files 124 124 Lines 2680 2538 -142 Branches 210 199 -11 ============================================ - Hits 1215 1171 -44 + Misses 1411 1316 -95 + Partials 54 51 -3 ```
alexander-yevsyukov commented 1 year ago

@dmdashenkov, if you can pick the latest version of logging baking in this PR, I'd be able to grab this version of Validation in my works on brining new stuff in core-java.

dmdashenkov commented 1 year ago

@armiol, @alexander-yevsyukov, PTAL.

dmdashenkov commented 1 year ago

@alexander-yevsyukov, PTAL again.