Closed yuri-sergiichuk closed 3 years ago
Merging #166 (cb2be82) into master (28748bf) will increase coverage by
0.26%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #166 +/- ##
============================================
+ Coverage 60.14% 60.41% +0.26%
- Complexity 210 213 +3
============================================
Files 93 93
Lines 2366 2382 +16
Branches 43 45 +2
============================================
+ Hits 1423 1439 +16
Misses 932 932
Partials 11 11
This PR fixes the handling of the Firebase RDB emulator endpoint. The DB URL may be of two formats:
https://<database-alias>.firebaseio.com
DB URL points to a remote Firebase RDB;http://<local-ip>:<local-port>?ns=<database-alias>
points to a local Firebase RDB emulator.For the latter, the
ns
part stands fornamespace
and is effectively used by the emulator as a way to determine the local database instance to be used. Prior to the improvement, such a query in the URL was not handled properly and it was not possible to connect to a specific database thus one should have to just guess which database would be used (from what I understood, if127.0.0.1
IP address is used, the DB name would be127
, forlocalhost
I was not able to determine which one is used).The PR also bumps the Jackson version to address security vulnerability.