Closed armiol closed 1 year ago
@YegorUdovchenko @dmitrykuzmin since you are the original reporters, please have a look.
@YegorUdovchenko @dmitrykuzmin in scope of the following PRs, I am going to update the Firebase Admin SDK to the latest 9.1.x version. This will affect the Java API of web
module as well. Please let me know if that's OK with you.
@YegorUdovchenko @dmitrykuzmin in scope of the following PRs, I am going to update the Firebase Admin SDK to the latest 9.1.x version. This will affect the Java API of
web
module as well. Please let me know if that's OK with you.
We'll have to version our server API during this migration anyway, so the Admin SDK upgrade is not a big deal.
Merging #195 (f75bd3a) into v1 (95a0105) will decrease coverage by
0.78%
. The diff coverage is9.52%
.
This PR addresses #188.
In particular, the following changes were made to the behaviour:
Calling
unsubscribe
for any subscription now leads to an immediate cancellation on both client- and server-side. Previously, all such cancellations were only processed during the next "keep-up" propagation.Client
now allows cancelling all known subscription viacancelAllSubscriptions()
no-args call. Its invocation leads to sending the bulk cancellation request to server-side, as well as shutting down the client-level subscriptions. Such an API is useful in case end-users choose to log out from the application.Also, this PR aims to improve the server-side memory consumption.
In particular, server-side holds a couple of internal registries to track active subscriptions. Previously, upon cancellation of a subscription, some of these registries were not affected, thus producing a memory leak. Now, each cancelled subscription is removed from all in-memory caches.
In future PRs there will be more updates to this repository, addressing the library updates available for both Java and client-side code.
The library version is set to
1.9.0-SNAPSHOT.10
.